Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: type-check stories during Storybook build #876

Merged
merged 3 commits into from
Sep 21, 2020
Merged

feat: type-check stories during Storybook build #876

merged 3 commits into from
Sep 21, 2020

Conversation

kylemh
Copy link
Contributor

@kylemh kylemh commented Sep 21, 2020

Resolves #668

@vercel

This comment has been minimized.

Sign in to view
@agilgur5 agilgur5 added the scope: templates Related to an init template, not necessarily to core (but could influence core) label Sep 21, 2020
@agilgur5 agilgur5 changed the title Ensure stories are type-checked feat: type-check stories during Storybook build Sep 21, 2020
agilgur5
agilgur5 requested changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch @kylemh 🙂 That should be the last solvable Storybook issue for now, 😅

Some small comments changes below

templates/react-with-storybook/.storybook/main.js Show resolved Hide resolved
templates/react-with-storybook/.storybook/main.js Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview September 21, 2020 18:35 Inactive
agilgur5
agilgur5 approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agilgur5 agilgur5 merged commit f1ddccb into jaredpalmer:master Sep 21, 2020
@kylemh kylemh deleted the patch-1 branch September 21, 2020 20:04
paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
@kylemh @agilgur5 @paul-vd
feat: type-check stories during Storybook build (jaredpalmer#876)
48dbd0e 
- add `check: true` to Storybook TS config
  - which runs `fork-ts-checker-webpack-plugin` to check types
     asynchronously in a separate process during Storybook build

Co-authored-by: Anton Gilgur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core)
Projects
None yet
Milestone
v0.14.0 - Dep Upgrades - Jest 25 + No...
Development

Successfully merging this pull request may close these issues.

stories dir is not being type checked during Storybook build
2 participants
@kylemh @agilgur5